Fix race condition in notification status upsert#2166
Closed
Copilot wants to merge 1 commit intofix/2164-notification-duplicationfrom
Closed
Fix race condition in notification status upsert#2166Copilot wants to merge 1 commit intofix/2164-notification-duplicationfrom
Copilot wants to merge 1 commit intofix/2164-notification-duplicationfrom
Conversation
Copilot
AI
changed the title
[WIP] Address feedback on duplicate notification error fix
Fix race condition in notification status upsert
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
createNotifiedArticleStatusmethod used a find-then-insert/update pattern that was vulnerable to a race condition: two concurrent transactions could both observe no existing row and both attempt an insert, causing a unique constraint violation onuser_id.Changes
INSERT ... ON DUPLICATE KEY UPDATEquery inUserNotificationStatusRepository, eliminating the race condition at the DB level.createNotifiedArticleStatusnow delegates entirely toupsertLastNotifiedArticleId— no JPAfindByUserIdcall, no branching.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.