Conversation
|
@Tom-Kingstone just to let you know, I have provided a |
jamesramsden-bh
left a comment
There was a problem hiding this comment.
Partial approval. I have spot tested wind rose creation manually, and wind rose created as expected.
I am having unrelated issues with my environment, so somebody else will need to run the unit tests before this PR can be fully approved.
jamesramsden-bh
left a comment
There was a problem hiding this comment.
Partial approval. I have spot tested wind rose creation manually, and wind rose created as expected.
I am having unrelated issues with my environment, so somebody else will need to run the unit tests before this PR can be fully approved.
NOTE: Depends on BHoM/Python_Toolkit#183
Issues addressed by this PR
Closes #311
See linked PR for more info.
Deprecated a couple of the inputs for the plot_windrose method as they no longer made any sense now that the polar plot method exists in Python_Toolkit.
Test files
Run unit tests and ensure they pass
Check the Wind class using jupyter to see that it works properly: import wind from an EPW file or openmeteo and try creating a number of different wind roses.
Changelog
Windclass toPython_ToolkitAdditional comments