Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The 300ms redirect setTimeout was not being cleared by the effect cleanup, which could fire onRedirect after the component unmounts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lukejosephy
approved these changes
Mar 6, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e9a254c to
555a64c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
new splash screen design from Holland
What changed
EnergyOnlySplashModal.tsxCheckIconcomponent: filled green circle with checkmark (complete) vs grey outline circle (pending), using the provided design asset pathsstyles.module.csssplashOverlay,splashCard,splashSpinner,splashSteps,splashStep,splashStepLabel,splashStepLabelCompleteMobile jitter fix
When a step completes, the label switches from
font-weight: 500→700. Bold text is wider, which would normally resize the container and shift the layout.Fix:
splashStepLabel::afterrenders an invisible bold ghost of the label text (height: 0; visibility: hidden; font-weight: 700; content: attr(data-label)). The element always occupies bold width, so the container never resizes when the state transitions — no layout shift.Test
mobile.mov
desktop.web.mov
🤖 Generated with Claude Code