use animator transform for PoseHandler in remote players#537
Merged
dooly123 merged 2 commits intoBasisVR:developerfrom Feb 16, 2026
Merged
use animator transform for PoseHandler in remote players#537dooly123 merged 2 commits intoBasisVR:developerfrom
dooly123 merged 2 commits intoBasisVR:developerfrom
Conversation
Collaborator
|
That will cause a performance degradation. I'm happy to merge it if you pre-store the transform as the other one was. |
Collaborator
|
crossing my fingers that its all ok :) basically desktop and vr are identical in operation over the network so should all be good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My avatar's animator is a child of the
BasisAvatarcomponent, which does not seem like it should be unsupported according to the docs and some comments I found in the code.I changed the PoseHandler to reference the animator's transform (instead of the root transform of BasisAvatar) which seems to align with the code on the sender side.
I only tested this fix in desktop mode but before the change, the avatar was stuck in T-Pose at origin on remote clients, and after the change, it seemed to work normally.