Update 'arkouda_viz' package and av.explore() #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
ajpotts
requested review from
1RyanK,
ItsQuinnMoore,
drculhane,
e-kayrakli and
jaketrookman
e-kayrakli
approved these changes
Feb 7, 2025
e-kayrakli
left a comment
e-kayrakli
left a comment
There was a problem hiding this comment.
With the caveat that this is the first time I am seeing this code, it looks good to me!
Author
|
I converted this PR to a draft, pending resolution of conflicts with main. |
github-merge-queue bot
pushed a commit
to Bears-R-Us/arkouda
that referenced
this pull request
Apr 23, 2025
Closes #4096. Required by Bears-R-Us/arkouda-contrib#179 Adds `numpy`-style optional `range` parameter to client histogram functions: * `histogram()` * `histogram2d()` * `histogramdd()` Switches the histograms produced by `histogramdd()` to contain `float` counts instead of integer counts, to match `numpy`. While there: * Makes `histogramdDMsg()` more efficient. * Factors out some histogram server code. * Removes the dependence of `histogramdd()` on `cumprod()`. * Cleans up Makefile to remove an extraneous `/` and trailing whitespace. Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
arkouda_vizpackages as follows:Updates the package to a recent version of
holoviews. Tested with Holoviews 1.20.Introduces caching in the
explore()function. This way it avoids recomputing the hashtable for the second time, which can happen due to how holoviews' "stream" machinery works. This also preserves the current zoom/position in the histogram while changing color maps.Updates the README to list correctly the functions that are available and to display the logo.
Other fixes in
explore()and other minor fixes and cleanups.Removes an explicit dependence on
bokeh, which is helpful when this package is not installed.arkouda_vizshould work withoutbokeh.Enables the user to set the default engine for all future calls to the API functions by updating
arkouda_viz.default_engineBumps the package minor version by 1.
The changes in
explore()require Arkouda's histogram-2D API to accept therangeargument, Bears-R-Us/arkouda#4078