Skip to content

Conversation

@jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Apr 19, 2025

PR Type

Enhancement


Description

  • Add Ruby 3.4.3 release configuration and metadata

  • Introduce install script for RubyGems update in Ruby 3.4.3

  • Update release and build properties for new version

  • Register Ruby 3.4.3 in releases list


Changes walkthrough 📝

Relevant files
Enhancement
install.bat
Add RubyGems install/update script for Ruby 3.4.3               

bin/ruby3.4.3/rubygems/install.bat

  • Add batch script to install and update RubyGems locally
  • Handles error checking for gem installation
  • +10/-0   
    bearsampp.conf
    Add Ruby 3.4.3 configuration file                                               

    bin/ruby3.4.3/bearsampp.conf

  • Add configuration file for Ruby 3.4.3
  • Specifies Ruby executables and bundle release placeholder
  • +5/-0     
    rubygems.properties
    Add RubyGems properties for Ruby 3.4.3                                     

    bin/ruby3.4.3/rubygems/rubygems.properties

  • Add RubyGems properties file for Ruby 3.4.3
  • Points to specific rubygems-update gem release
  • +1/-0     
    releases.properties
    Add Ruby 3.4.3 to releases registry                                           

    releases.properties

    • Register Ruby 3.4.3 with download URL in releases list
    +1/-0     
    Configuration changes
    build.properties
    Update bundle release version for new Ruby release             

    build.properties

    • Update bundle release version to 2025.4.19
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @jwaisner jwaisner requested a review from N6REJ as a code owner April 19, 2025 21:39
    @jwaisner jwaisner added the enhancement ✨ Improve program label Apr 19, 2025
    @qodo-code-review
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Error Handling

    The script checks for errors after gem install but not after gem update. Consider adding error checking for the update command as well to ensure both operations complete successfully.

    "%RUBYBINPATH%\gem.cmd" update --system --no-document
    URL Verification

    The URL points to a specific gem file with today's date (2025.4.19) which should be verified to ensure it exists and is accessible before merging.

    rubygems = https://github.com/Bearsampp/modules-untouched/releases/download/ruby-2025.4.19/rubygems-update-3.6.8.gem

    @qodo-code-review
    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Check file existence first

    The script assumes that rubygems-update.gem exists in the current directory, but
    it doesn't verify this. Add a check to ensure the gem file exists before
    attempting installation.

    bin/ruby3.4.3/rubygems/install.bat [7-8]

    +IF NOT EXIST rubygems-update.gem (
    +  echo Error: rubygems-update.gem not found in current directory
    +  exit /b 1
    +)
     CALL "%RUBYBINPATH%\gem.cmd" install rubygems-update.gem --local --no-document
     IF %ERRORLEVEL% NEQ 0 exit /b %ERRORLEVEL%
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: This suggestion adds important error handling by checking if the gem file exists before attempting installation. This prevents cryptic errors and provides a clear message to users when the file is missing, improving robustness.

    Medium
    Add error handling

    The script doesn't check for errors after running the system update command. Add
    error handling to ensure the update completed successfully.

    bin/ruby3.4.3/rubygems/install.bat [10]

    -"%RUBYBINPATH%\gem.cmd" update --system --no-document
    +CALL "%RUBYBINPATH%\gem.cmd" update --system --no-document
    +IF %ERRORLEVEL% NEQ 0 exit /b %ERRORLEVEL%
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    __

    Why: Adding error handling for the system update command is important for script reliability. The current implementation doesn't check if the update succeeded, which could lead to silent failures. This change ensures the script exits with the appropriate error code.

    Medium
    • More

    @N6REJ N6REJ merged commit 9070bf0 into main Apr 23, 2025
    @N6REJ N6REJ deleted the 3.4.3 branch April 23, 2025 13:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    enhancement ✨ Improve program

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants