-
Notifications
You must be signed in to change notification settings - Fork 1
add round-trip for share derived via interpolation #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scgbckbone
wants to merge
3
commits into
BenWestgate:master
Choose a base branch
from
scgbckbone:test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| from itertools import product | ||
| from src.codex32.codex32 import Codex32String, IDX_ORDER | ||
|
|
||
|
|
||
| def recover_with_bytes(hrp, header_str, share_idx_list, share_bytes_list, target="s"): | ||
| """Recover codex32 secret from share bytes assuming default padding.""" | ||
| pad_len = (5 - (len(share_bytes_list[0]) * 8) % 5) % 5 | ||
| default_padded_shares = IDX_ORDER[: len(share_idx_list)] | ||
| pad_candidates = product(range(1 << pad_len), repeat=len(share_idx_list)) | ||
| for pad_vals in pad_candidates: | ||
| given_shares = [] | ||
| for idx, data, pad_val in zip(share_idx_list, share_bytes_list, pad_vals): | ||
| given_shares.append(Codex32String.from_seed(data, hrp + '1' + header_str + idx, pad_val)) | ||
| for share_idx in default_padded_shares: | ||
| initial_share = Codex32String.interpolate_at(given_shares, share_idx) | ||
| round_tripped_initial_share = Codex32String.from_seed(initial_share.data, hrp + "1" + header_str + share_idx) | ||
| if str(round_tripped_initial_share) != str(initial_share): | ||
| break | ||
| return Codex32String.interpolate_at(given_shares, target) | ||
|
|
||
| def test_round_trip_recovery(): | ||
| # secret share from seed | ||
| s = Codex32String.from_seed(bytes.fromhex("68f14219957131d21b615271058437e8"), "ms13k00ls") | ||
| assert s.s == "ms13k00lsdrc5yxv4wycayxmp2fcstppharks8z0r84pf3uj" | ||
|
|
||
| # derive 'a' via proposed BIP-85 | ||
| a = Codex32String.from_seed(bytes.fromhex("641be1cb12c97ede1c6bad8edf067760"), "ms13k00la") | ||
| assert a.s == "ms13k00lavsd7rjcje9ldu8rt4k8d7pnhvppyrt5gpff9wwl" | ||
|
|
||
| # derive 'c' via proposed BIP-85 | ||
| c = Codex32String.from_seed(bytes.fromhex("61b3c4052f7a31dc2b425c843a13c9b4"), "ms13k00lc") | ||
| assert c.s == "ms13k00lcvxeugpf00gcac26ztjzr5y7fkjl7fx7nx7ykhkr" | ||
|
|
||
| # derive next share via interpolation | ||
| d = Codex32String.interpolate_at([s, a, c], "d") | ||
| assert d.s == "ms13k00ldp4v5nw8lph96x47mjxzgwjexe44p32swkq99e0w" | ||
|
|
||
| # now round-trip d share ('d' is derived via interpolation, NOT via 'from_seed') | ||
| dd = Codex32String.from_seed(d.data, "ms13k00ld") | ||
| # they are NOT equal after round-trip - seem we miss padding at interpolation level | ||
| # assert dd.s == d.s # FAIL (should equal) | ||
|
|
||
| # irrelevant | ||
| # e = Codex32String.interpolate_at([s, a, c], "e") | ||
| # assert e.s == "ms13k00lezuknydaaygk5u20zs4fm736vj909mdj6xqp8pc2" | ||
| # | ||
| # f = Codex32String.interpolate_at([s, a, c], "f") | ||
| # assert f.s == "ms13k00lf0ehe53zsu6vrxcjjh9v7wzsa83mqfvku3fd8kem" | ||
|
|
||
| # recover from shares, use 'd' without round-trip | ||
| rec_s = Codex32String.interpolate_at([a, d, c], "s") | ||
| # recover from shares, use 'd' after round-trip | ||
| rec_ss = Codex32String.interpolate_at([a, dd, c], "s") | ||
|
|
||
|
|
||
| xx = recover_with_bytes("ms", "3k00l", ["a", "d", "c"], [a.data, d.data, c.data]) | ||
| # recover with round-trip D share | ||
| yy = recover_with_bytes("ms", "3k00l", ["a", "d", "c"], [a.data, dd.data, c.data]) | ||
|
|
||
| print(" s:", s.data.hex()) | ||
| print(" rec_s:", rec_s.data.hex()) | ||
| print("rec_ss:", rec_ss.data.hex()) | ||
| print("rec_xx:", xx.data.hex()) | ||
| print("rec_yy:", yy.data.hex()) | ||
| assert s.data == rec_s.data | ||
| assert s.data == yy.data # FAIL | ||
| assert s.data == xx.data # FAIL | ||
| assert s.data == rec_ss.data # FAIL | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recover_from_bytesexpects the first k non-s shares to use the default padding. So if you encode the secret rather than recover it with interpolation we'd need to tweak thedefault_padded_sharesto include 's'. see the comment on that line.However for bip85 we don't directly encode secrets unless threshold is "0".