fix(sdk-coin-trx): fix BANDWIDTH transaction signature mismatch #7954
+586
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RROR) Fix protobuf3 serialization mismatch for TRON BANDWIDTH transactions. Problem: - BitGoJS explicitly encoded resource=BANDWIDTH (value 0) in protobuf - TRON node re-serializes transactions and omits default values per protobuf3 - Different bytes → different txID → signature mismatch (SIGERROR) Solution: - Omit resource field when it's BANDWIDTH (the default value = 0) - Update decode functions to treat missing resource as BANDWIDTH - Add comprehensive round-trip tests for BANDWIDTH serialization Files changed: - freezeBalanceTxBuilder.ts: omit resource field for BANDWIDTH - unfreezeBalanceTxBuilder.ts: omit resource field for BANDWIDTH - delegateResourceTxBuilder.ts: omit resource field for BANDWIDTH - undelegateResourceTxBuilder.ts: omit resource field for BANDWIDTH - utils.ts: handle missing resource as BANDWIDTH in decode functions Ticket: SC-5030
abhijit0943
force-pushed
the
SC-5030
branch
2 times, most recently
from
92e15f3 to
24e133e
Compare
abhijit0943
force-pushed
the
SC-5030
branch
2 times, most recently
from
76382a5 to
ee32ee3
Compare
Exclude the tar vulnerability instead of bumping version because: - Lerna requires tar v6, but fix only exists in v7.5.4+ - Forcing tar v7.x breaks lerna publishing - This is a race condition in tar's path reservation system Ticket: SC-5030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix protobuf3 serialization mismatch for TRON BANDWIDTH transactions.
Problem:
Solution:
Files changed:
Ticket: SC-5030