fix(sweep): split sweep calls by owner address for correct WIF selection#82
Open
fix(sweep): split sweep calls by owner address for correct WIF selection#82
Conversation
The @1sat/actions sweep functions accept a single WIF per call. When ordinals, BSV-21 tokens, or funding UTXOs exist on both legacy pay and ord addresses, using a single WIF based on the first item's owner causes signing failures for items on the other address. Group all asset types by owner address before sweeping so each call uses the correct WIF. Also fixes the same bug for BSV funding UTXOs, which was hardcoded to legacyPayWif despite scanning both addresses. BSV-20 token sweeping is intentionally omitted -- @1sat/actions does not expose a sweepBsv20 function.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sweepOrdinalscalls per group.sweepBsv21calls.legacyPayWifdespitescanLegacyAddressesmerging funding UTXOs from both addresses. Now also groups by owner.@1sat/actionsdoes not expose asweepBsv20function.The core change is a
groupByOwnerhelper that partitionsWalletOrdinal[]by theownerfield. Each sweep function now iterates over these groups, selecting the correct WIF (legacyPayWiforlegacyOrdWif) per group.Test plan