Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GoFortress benchstat setup to require Go 1.25+, aligning the composite action’s version gate and user-facing messaging with the newer benchstat toolchain expectation.
Changes:
- Raised the minimum Go version check for benchstat installation from 1.23 to 1.25 in the
setup-benchstatcomposite action. - Bumped MAGE-X and benchstat tool versions in CI environment configuration.
- Updated the test-matrix workflow note to reflect the new Go 1.25+ benchstat requirement.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/fortress-test-matrix.yml | Updates benchstat setup note to reference Go 1.25+ requirement. |
| .github/env/10-mage-x.env | Bumps MAGE-X version and benchstat pseudo-version used by workflows/actions. |
| .github/actions/setup-benchstat/action.yml | Updates go-version requirement messaging and changes version-check threshold to 1.25+. |
Comments suppressed due to low confidence (1)
.github/workflows/fortress-test-matrix.yml:187
- With the action now skipping benchstat for Go < 1.25, this workflow’s current matrix (GO_PRIMARY_VERSION/GO_SECONDARY_VERSION are set to 1.24.x in
.github/env/00-core.env) will always skip benchstat on all runners. If benchmark comparison tests depend on benchstat being present, consider bumping the CI Go version(s) to 1.25+ (or installing benchstat using a separate, compatible toolchain) so benchmarks don’t silently lose comparison coverage.
# Setup benchstat (required for benchmark comparison tests)
# Note: benchstat requires Go 1.25+, action will skip for older versions
# --------------------------------------------------------------------
- name: 📊 Setup benchstat
uses: ./.github/actions/setup-benchstat
with:
benchstat-version: ${{ env.MAGE_X_BENCHSTAT_VERSION }}
runner-os: ${{ matrix.os }}
go-version: ${{ matrix.go-version }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
MINOR -lt 23toMINOR -lt 25)Why It Was Necessary
Testing Performed
Impact / Risk