Fix compilation warning on Elixir 1.11#244
Open
axelson wants to merge 1 commit intoBlakeWilliams:masterfrom
Open
Fix compilation warning on Elixir 1.11#244axelson wants to merge 1 commit intoBlakeWilliams:masterfrom
axelson wants to merge 1 commit intoBlakeWilliams:masterfrom
Conversation
Here's an example of the warning: ``` ==> slack Compiling 10 files (.ex) warning: redefining @doc attribute previously set at line 88. Please remove the duplicate docs. If instead you want to override a previously defined @doc, attach the @doc attribute to a function head: @doc """ new docs """ def lookup_channel_name(...) lib/slack/lookups.ex:95: Slack.Lookups.lookup_channel_name/2 Compilation failed due to warnings while using the --warnings-as-errors option ``` On previous versions the initial `@doc` was silently ignored: ``` iex(1)> h Slack.Lookups.lookup_channel_name def lookup_channel_name(channel_id, slack) Turns a Slack private channel ID ("G…") into a string in the format "#CHANNEL_NAME". ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an example of the warning:
On previous versions the initial
@docwas silently ignored:This change is backwards compatible with older elixir versions.