Function to set additional loads#8
Open
korbireischl wants to merge 11 commits intoBlockResearchGroup:mainfrom
Open
Function to set additional loads#8korbireischl wants to merge 11 commits intoBlockResearchGroup:mainfrom
korbireischl wants to merge 11 commits intoBlockResearchGroup:mainfrom
Conversation
Author
|
I noticed that when calculating forces in SI units, the values became too large for the solver and it no longer converged reliably. I reverted to using block mass rather than weight for the force vector. Instead I normalized the additional loads by dividing them by the variable for gravitational acceleration, ensuring they remain in the same mass-based units. Now the solution behaves as intended, and I’ve restored the original test files. Users can still define the additional load in their preferred units (by default in Newtons with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function has been added for setting additional load on blocks. This works like density_setup by defining a dictionary with entries for each block.
To work in the correct units, I adjusted the calculation of the self-weight in external_force_setup by adding a variable for gravitational acceleration. Now the calculation of the external forces uses SI units. To pass the tests, I had to set the value of gravity in them to 1.
What type of change is this?
Checklist
CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.I added a short documentation in the code and docs/api. Do you need additional documentation? And should I provide an example that uses external loads?
To display the added loads in the compas_viewer, the weight function must be adapted. I will come to this shortly.