BUG: Fix argument handling in nxrunner#1627
Open
imikejackson wants to merge 1 commit into
Open
Conversation
1cf9dc3 to
893d4b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the two nearly-identical SIMPL pipeline conversion options in
nxrunnerinto a single--convert/-cflag and cleans up the related help output.What changed
--convert-output/-cointo--convert/-c. Previously there were two flags whose only difference was print-to-stdout vs. write-to-file. The confusingly similar pair (--convertvs--convert-output,-cvs-co) was an argument-handling hazard.--convertnow does the useful thing: it writes the converted pipeline to a.d3dpipelinefile next to the input.ConvertOutputargument type, its parsing branch, its help-menu dispatch, the orphanedDisplayConvertOutputHelp()function, and the unusedk_ConvertOutputParam{Long,Short}constants.--convert-outputflag; they now reference--convert.\t(tab + space) prefixes with consistent two-space indentation.docs/NX_CLI.mdto document the single--convertflag and its save-to-file behavior.🤖 Generated with Claude Code