VV: Compute Feature Neighbor Misorientations and Compute Kernel Average Misorientation fully V&V'ed#1630
Open
imikejackson wants to merge 2 commits into
Conversation
imikejackson
requested review from
JDuffeyBQ and
nyoungbq
and removed request for
nyoungbq
imikejackson
force-pushed
the
topic/vv/ComputeFeatureNeighborMisorientationsFilter
branch
3 times, most recently
from
7719550 to
ac6e8ff
Compare
Summary: - Found and fixed 1 bug (divisor clobbered inside inner j-loop of algorithm.cpp); - documented 2 deviations from DREAM3D 6.5.171 (D1 divisor bug, D2 EbsdLib 2.4.1 precision); - retired 2 tests (circular-oracle exemplar consumer + UNIMPLEMENTED stub); - unit tests replaced with 4 inlined *Class 1 (Analytical) + Class 4 (Invariant)* test fixtures; - added 3 V&V source-tree deliverables (report, deviations, provenance); - fixed pipeline-name typo in user-facing doc.
Summary: - Confirmed no SIMPLNX-side bugs (legacy D2 inner-x-loop typo was corrected at port time); - documented 2 deviations from DREAM3D 6.5.171 (D1 EbsdLib 2.4.1 precision, D2 legacy kernel-bound typo); - retired 1 test (circular-oracle exemplar consumer regenerated from pre-EbsdLib-2.4.1 SIMPLNX output); - unit tests replaced with 5 inlined *Class 1 (Analytical) + Class 4 (Invariant)* test fixtures; - added 3 V&V source-tree deliverables (report, deviations, provenance); - fixed user-facing doc (pipeline-name typo, dropped orphan MassifPipeline reference, added EBSD_File_Processing examples).
imikejackson
force-pushed
the
topic/vv/ComputeFeatureNeighborMisorientationsFilter
branch
from
ac6e8ff to
6aa5c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes some long standing bugs. See the V&V docs for full details