VV: Compute Feature Neighbor C-Axis Misalignments fully V&V'ed

src/Plugins/OrientationAnalysis/docs/ComputeFeatureNeighborCAxisMisalignmentsFilter.md

@@ -16,9 +16,9 @@ There are 2 outputs from this filter:
 
 ### Notes
 
-**NOTE:** Only features with identical phase values and a crystal structure of **Hexagonal_High** will be calculated. If two features have different phase values or a crystal structure that is *not* Hexagonal_High then a value of NaN is set for the misorientation.
+**NOTE:** Only features with identical phase values and a crystal structure of **Hexagonal_High** (6/mmm) or **Hexagonal_Low** (6/m) will be calculated. If two features have different phase values, or if the shared phase has a crystal structure that is not one of the two hexagonal Laue classes, then a value of NaN is set for the misalignment.
 
-Results from this filter can differ from its original version in DREAM.3D 6.5.171 by around 0.0001. This version uses double precision and Eigen for matrix operations which account for the differences in output.
+Results from this filter can differ from its original version in DREAM.3D 6.5.171 by around 0.0001 degrees. This version uses double precision and Eigen for matrix operations which account for the differences in output.
 
 % Auto generated parameter table will be inserted here
 

src/Plugins/OrientationAnalysis/src/OrientationAnalysis/Filters/Algorithms/ComputeFeatureNeighborCAxisMisalignments.cpp

@@ -104,11 +104,16 @@ Result<> ComputeFeatureNeighborCAxisMisalignments::operator()()
     const NeighborList<int>::VectorType& currentNeighborList = neighborList[featureIdx];
     auto& currentMisalignmentList = misalignmentLists[featureIdx];
     currentMisalignmentList.resize(currentNeighborList.size(), -1.0);
+    // Initialize the divisor once per outer-loop iteration (per feature). Previously this was
+    // assigned inside the inner j-loop, which clobbered the per-mismatch decrement below — the
+    // resulting divisor only reflected the LAST neighbor's match/mismatch state, producing wrong
+    // per-feature averages whenever neighbors had mixed phases. Fixed 2026-06-04 during V&V cycle
+    // (sibling of the same divisor bug fixed in ComputeFeatureNeighborMisorientations on 2026-06-02).
+    hexNeighborListSize = currentNeighborList.size();
     for(usize j = 0; j < currentNeighborList.size(); j++)
     {
       int neighborFeatureId = currentNeighborList[j];
       xtalPhase2 = crystalStructures[featurePhases[neighborFeatureId]];
-      hexNeighborListSize = currentNeighborList.size();
 
       // If both the feature and the neighbor are both Hexagonal Phases
       if(xtalPhase1 == xtalPhase2 && (xtalPhase1 == ebsdlib::CrystalStructure::Hexagonal_High || xtalPhase1 == ebsdlib::CrystalStructure::Hexagonal_Low))

src/Plugins/OrientationAnalysis/test/CMakeLists.txt

@@ -138,7 +138,6 @@ if(EXISTS "${DREAM3D_DATA_DIR}" AND SIMPLNX_DOWNLOAD_TEST_FILES)
   download_test_data(DREAM3D_DATA_DIR ${DREAM3D_DATA_DIR} ARCHIVE_NAME align_sections.tar.gz SHA512 b6892e437df86bd79bd2f1d8f48e44d05bfe38b3453058744320bfaf1b1dc461a484edc9e593f6b9de4ad4d04c41b5dbd0a30e6fc605341d046aec4c3062e33e)
   download_test_data(DREAM3D_DATA_DIR ${DREAM3D_DATA_DIR} ARCHIVE_NAME 7_bad_data_neighbor_orientation_check.tar.gz SHA512 60089eecfe679466f63ef46839f194f83185a5987f51a0e23b9670e50d967ae49451bcfa43c0d44d6fb12cd55b73d208b36825251842d2b2568ffe521be12fbe)
   download_test_data(DREAM3D_DATA_DIR ${DREAM3D_DATA_DIR} ARCHIVE_NAME caxis_data.tar.gz SHA512 56468d3f248661c0d739d9acd5a1554abc700bf136586f698a313804536916850b731603d42a0b93aae47faf2f7ee49d4181b1c3e833f054df6f5c70b5e041dc)
-  download_test_data(DREAM3D_DATA_DIR ${DREAM3D_DATA_DIR} ARCHIVE_NAME compute_feature_neighbor_caxis_misalignments.tar.gz SHA512 955cd35b7ae24579ef9c533df34e1118012a8e5e2a71f8613117c714fc220c5dfa78d91a2964b41752e70684b79d4aa790e488e9a7be4c9dcf7b642ee2897ceb)
   download_test_data(DREAM3D_DATA_DIR ${DREAM3D_DATA_DIR} ARCHIVE_NAME compute_misorientations.tar.gz SHA512 31e649921eebf1e5dd1882279d0ec4d640e2c377a9edbb24d7b81eba74ec3656bd6236b1d1c038aa2123aa5959b529c144915f885b8e08fe1a90eee60f52e766)
   download_test_data(DREAM3D_DATA_DIR ${DREAM3D_DATA_DIR} ARCHIVE_NAME compute_twin_boundaries_test_v2.tar.gz SHA512 5091af4baea7215e8184adfb6bf657db003e509cfaa0e8c612f196494b5119291f9e82b1b3aa3b84715fd949ec72492cdc794bb1cbcfe5b540144b629e85ff4f)
   download_test_data(DREAM3D_DATA_DIR ${DREAM3D_DATA_DIR} ARCHIVE_NAME convert_hex_grid_to_square_grid_test.tar.gz SHA512 bb672ebbe2540ba493ad95bea95dac1f85b5634ac3311b5aa774ce3d2177103d1b45a13225221993dd40f0cbe02daf20ccd209d4ae0cab0bf034d97c5b234ba4)

vcpkg-configuration.json

@@ -8,7 +8,7 @@
     {
       "kind": "git",
       "repository": "https://github.com/bluequartzsoftware/simplnx-registry",
-      "baseline": "ca7046ad28b4885b018e4ab5fcf43333460d82b2",
+      "baseline": "b9f4d4c072f0ffc3291378dc03c4f6b38f0b4743",
       "packages": [
         "benchmark",
         "blosc",

vcpkg.json

@@ -83,7 +83,7 @@
       "dependencies": [
         {
           "name": "ebsdlib",
-          "version>=": "2.4.0"
+          "version>=": "2.4.1"
         }
       ]
     },