Skip to content

feat(cicd): centralize pytest config#83

Open
BobTheBuidler wants to merge 2 commits intomasterfrom
feat/pytest-config-20260120
Open

feat(cicd): centralize pytest config#83
BobTheBuidler wants to merge 2 commits intomasterfrom
feat/pytest-config-20260120

Conversation

@BobTheBuidler
Copy link
Copy Markdown
Owner

Summary

  • move pytest CLI args into config files
  • keep workflows invoking pytest without inline args

Manual testing

  • not run (not requested)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2446f9b6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +3 to +4
testpaths =
benchmarks
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix testpaths so CodSpeed collects benchmarks

Because the workflow now runs pytest with -c benchmarks/pytest-codspeed.ini, pytest sets its rootdir to the directory containing that config. With testpaths = benchmarks here, collection resolves to benchmarks/benchmarks, which does not exist in this repo, so CodSpeed will collect zero tests and the benchmark run silently does nothing. To ensure benchmarks run, make testpaths relative to the config directory (e.g., .) or drop testpaths and pass the path explicitly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant