feat(cicd): centralize pytest config#83
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2446f9b6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| testpaths = | ||
| benchmarks |
There was a problem hiding this comment.
Fix testpaths so CodSpeed collects benchmarks
Because the workflow now runs pytest with -c benchmarks/pytest-codspeed.ini, pytest sets its rootdir to the directory containing that config. With testpaths = benchmarks here, collection resolves to benchmarks/benchmarks, which does not exist in this repo, so CodSpeed will collect zero tests and the benchmark run silently does nothing. To ensure benchmarks run, make testpaths relative to the config directory (e.g., .) or drop testpaths and pass the path explicitly.
Useful? React with 👍 / 👎.
Summary
Manual testing