Skip to content

New Crowdin updates#55

Closed
gabitoesmiapodo wants to merge 6 commits into
feat/internationalization-setup-for-swap-cow-fifrom
l10n_feat/internationalization-setup-for-swap-cow-fi
Closed

New Crowdin updates#55
gabitoesmiapodo wants to merge 6 commits into
feat/internationalization-setup-for-swap-cow-fifrom
l10n_feat/internationalization-setup-for-swap-cow-fi

Conversation

@gabitoesmiapodo
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Canceled Canceled Oct 16, 2025 1:52pm

@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates localization files with new translations from Crowdin. The changes involve reorganizing translation entries by moving some strings between different source file references and marking others as obsolete.

Key changes:

  • Relocated "Approve and Swap" and "Approve, Swap & Bridge" strings from useGetConfirmButtonLabel.ts to tradeButtonsMap.tsx
  • Updated "Swap and Bridge" status from obsolete to active in en-US, while marking it obsolete in es-ES and ru-RU
  • Added reference to TradeButtons/index.tsx for the "Swap" msgid group in en-US

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Updated revision date, added empty translations for new strings, marked old entries as obsolete, removed TradeButtons reference
apps/cowswap-frontend/src/locales/es-ES.po Updated revision date, added empty translations for new strings, marked old entries as obsolete, removed TradeButtons reference
apps/cowswap-frontend/src/locales/en-US.po Removed strings from useGetConfirmButtonLabel, reactivated "Swap and Bridge", reactivated "Approve and swap", added TradeButtons reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

msgid "Swap and Bridge"
msgstr "Поменять местами"
#~ msgid "Swap and Bridge"
#~ msgstr "Swap and Bridge"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation should retain the original Russian translation 'Поменять местами' instead of reverting to English 'Swap and Bridge'. This preserves translation history correctly.

Suggested change
#~ msgstr "Swap and Bridge"
#~ msgstr "Поменять местами"

Copilot uses AI. Check for mistakes.
Comment on lines +5054 to +5055
#~ msgid "Approve and swap"
#~ msgstr "Approve and swap"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation should retain the original Russian translation 'Одобрить и заменить' instead of reverting to English 'Approve and swap'. This preserves translation history correctly.

Copilot uses AI. Check for mistakes.
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 16, 2025
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch October 16, 2025 13:55
@gabitoesmiapodo gabitoesmiapodo review requested due to automatic review settings March 23, 2026 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants