Skip to content

[MA-45]: Updated the heading element tag #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayush-chauhan233 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MA-45]: Updated the heading element tag #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion webapp/channels/src/components/team_settings_modal/team_settings_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ const TeamSettingsModal = ({onExited, canInviteUsers}: Props) => {
id='teamSettingsModalLabel'
closeButton={true}
>
<Modal.Title componentClass='h1'>
<Modal.Title
componentClass='h2'
className='modal-header__title'
>
{formatMessage({id: 'team_settings_modal.title', defaultMessage: 'Team Settings'})}
</Modal.Title>
</Modal.Header>
Expand Down
3 changes: 2 additions & 1 deletion webapp/channels/src/components/user_settings/modal/user_settings_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,9 @@ class UserSettingsModal extends React.PureComponent<Props, State> {
closeButton={true}
>
<Modal.Title
componentClass='h1'
componentClass='h2'
id='accountSettingsModalLabel'
className='modal-header__title'
>
{modalTitle}
</Modal.Title>
Expand Down
11 changes: 10 additions & 1 deletion webapp/channels/src/sass/components/_settings-modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
@use "utils/functions";

.app__body {
.settings-modal {
.settings-modal {
h3 {
font-size: 18px;
}

.modal-header {
border-bottom: 1px solid rgba(var(--center-channel-color-rgb), 0.08);

&__title {
color: var(--center-channel-color);
font-family: 'Metropolis', serif;
Copy link
Copy Markdown

@SaurabhSharma-884 SaurabhSharma-884 Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where are we adding these styles?

Copy link
Copy Markdown
Author

@ayush-chauhan233 ayush-chauhan233 Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took reference from notification header
Screenshot from 2025-01-13 16-49-15

font-size: 22px;
font-weight: 600;
line-height: 28px;
word-break: break-word;
}
}

// Tabs
Expand Down