Skip to content

Check EEPROM version and CRC on load #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitchone merged 1 commit into from
Jun 10, 2026
Merged

Check EEPROM version and CRC on load #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/ThingSetPersistence.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ ThingSetPersistence::ThingSetPersistence(const device *device) : _device(device)
bool ThingSetPersistence::load()
{
StreamingZephyrEepromThingSetBinaryDecoder decoder(_device, 0);

if (decoder.isEmpty()) {
return false;
}

if (decoder.getVersion() != CONFIG_THINGSET_PLUS_PLUS_EEPROM_DATA_VERSION) {
LOG_WARN("EEPROM data version %d does not match expected version %d, "
"keeping default values",
decoder.getVersion(), CONFIG_THINGSET_PLUS_PLUS_EEPROM_DATA_VERSION);
return false;
}

return decoder.decodeMap<uint16_t>([&](uint16_t id) {
ThingSetNode *node;
if (!ThingSetRegistry::findById(id, &node)) {
Expand All @@ -34,7 +46,7 @@ bool ThingSetPersistence::load()
return decodable->decode(decoder);
}
return false;
});
}) && decoder.verify();
}

bool ThingSetPersistence::save()
Expand Down
Loading