Cleaning NCQ Code#38
Open
felipejrabelo wants to merge 2 commits into
Open
Conversation
some changes in cli.js ncq-cmd.js ncq-cmd-tests.js
Owner
|
Hi Felipe, Thanks for the pull request. I will give this a proper check after our session (I don't want to make any changes until the sessions are complete).
Yep, for the running of the sessions we need to keep a user's code for research purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT NEED TO ACCEPT THIS PULL REQUEST
NCQ might have been changed locally in the author's computer (out of sync).
Just started doing some code cleaning:
Removed a duplicated IF statement to avoid extra comparisons inside a loop.
Started to use string interpolation instead concatenation.
Add constants to avoid string repetitions all over the code.
All tests passed after changes !
I have notice that by starting two process of NCQ the temporary folders (tmp1, tmp2,...) can be replaced or erased by one process or another cause the code do not check if the folder already exists.