fix: equation card accent rail no longer pokes past rounded corner (#3)#7
Merged
Merged
Conversation
Task: fix UI glitch in the accounting-equation hero card where the blue accent rail's square top/bottom corners protruded past the card's 14px rounded corners (issue #3). Reproduced in both light and dark themes. Key decision: inset the `::before` rail vertically by the card radius (top/bottom: 14px) so it stays within the straight part of the left edge, rather than relying on `overflow:hidden` (which doesn't clip the pseudo-element's corner cleanly) or a matching border-radius (which clamps to ~4px on the 4px-wide rail and stays effectively square). Added rounded right end (border-radius: 0 3px 3px 0) for a clean cap. Files changed: ledger_lab/ledger_lab/page/ledger_lab/ledger_lab.js Verified: agent-browser on ledger.localhost (/app/ledger-lab), top- and bottom-left corners clean in light + dark mode. Notes for next iteration: remaining open issue is #5 (basic filters in transactions list — show-cancelled toggle + root-type filter). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the UI glitch in the accounting-equation hero card where the blue accent rail's square corners protruded past the card's rounded (14px) corners.
Closes #3
Cause
The
.ll-equation::beforerail was positionedtop:0; bottom:0with square corners. At the rounded top-/bottom-left corners the rail's square corner sat outside the card's curve, andoverflow:hiddenon the parent doesn't clip the pseudo-element's corner cleanly. A matchingborder-radiusdoesn't help either — on a 4px-wide rail a 14px radius clamps down to ~4px and stays effectively square.Fix
Inset the rail vertically by the card radius (
top:14px; bottom:14px) so it lives entirely within the straight part of the left edge, never entering the rounded-corner zone. Added a small rounded right cap (border-radius: 0 3px 3px 0).Verification
agent-browser on
ledger.localhost(/app/ledger-lab):Both top-left and bottom-left corners verified clean in light and dark themes.
🤖 Generated with Claude Code