fix: recover missing verification JSONs after interrupted CI#4
Merged
Conversation
When a contract already exists on-chain but the verification standard-json-input file is missing (e.g. CI interrupted after deploy but before file write), the early return in __deploy() now detects the missing file and regenerates it. Changes: - Extract _getStandardJsonInputPath() helper to DRY path construction - Add verification JSON recovery logic to __deploy() early return block - Add regression test with VerificationRecoveryHelper mock
Use a dedicated "recovery-test" subfolder for VerificationRecoveryHelper to prevent Forge's vm.revertToState() from restoring stale file-system state (corrupted standard-json-input files) across test boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_getStandardJsonInputPath()helper to DRY the path construction used in_saveContractToStandardJsonInput,_checkStandardJsonInput, and the new recovery logic-latest.jsonalways-write fix) — always persist artifacts regardless of_hasNewDeploymentsTest plan
forge fmtpasses on modified filesforge test)test_VerificationJsonRecoveredAfterInterruptedCItest validates the 4-step scenario: deploy → delete JSON → re-deploy (early return) → assert JSON recovered