Fix hardcoded localhost URL in FileURLService breaking Docker deployment#26
Draft
Fix hardcoded localhost URL in FileURLService breaking Docker deployment#26
Conversation
Co-authored-by: BukeLy <19304666+BukeLy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove hardcoded localhost URL from file service
Fix hardcoded localhost URL in FileURLService breaking Docker deployment
Dec 15, 2025
BukeLy
reviewed
Dec 15, 2025
Comment on lines
-21
to
+29
| def __init__(self, base_url: str = "http://localhost:8000", | ||
| def __init__(self, base_url: Optional[str] = None, | ||
| temp_dir: str = "/tmp/rag-files"): | ||
| # 从环境变量读取 base_url,移除硬编码默认值 | ||
| base_url = base_url or os.getenv("FILE_SERVICE_BASE_URL") | ||
| if not base_url: | ||
| raise ValueError( | ||
| "FILE_SERVICE_BASE_URL 环境变量未设置。" | ||
| "请在 .env 文件中配置 FILE_SERVICE_BASE_URL=http://your-ip:8000" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
已更新 env.example,添加了 FILE_SERVICE_BASE_URL 的必须配置说明,并将默认值从 localhost 改为 your-ip 占位符,避免误用。(35e94f5)
Co-authored-by: BukeLy <19304666+BukeLy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileURLServicehardcodedhttp://localhost:8000as defaultbase_url, causing remote MinerU API to fail in Docker environments where localhost is unreachable.Changes
FileURLService.__init__: Remove hardcoded default, requireFILE_SERVICE_BASE_URLenv varget_file_service(): Delegate env var handling to__init__instead of duplicating logicenv.example: UpdateFILE_SERVICE_BASE_URLwith clear "must configure" warning and placeholder valuehttp://your-ip:8000instead of localhostBehavior
Explicit
base_urlparameter still works for testing/override scenarios.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.