Enforce float64 internal RBF/grid coefficient handling with wpfloat outputs#1288
Draft
Copilot wants to merge 3 commits into
Draft
Enforce float64 internal RBF/grid coefficient handling with wpfloat outputs#1288Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Refactor handling of rbf coefficients and grid related coefficients
Enforce float64 internal RBF/grid coefficient handling with wpfloat outputs
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns coefficient precision flow across computation and savepoint loading: RBF/grid coefficients are computed/loaded in float64 for numerical stability, then exposed to consumers in
wpfloatregardless ofwpfloat/vpfloatruntime settings.RBF computation precision contract
rbf_interpolationto run internal coefficient assembly/solve/normalization in float64.wpfloat.Savepoint consumption precision contract
read_static_fields(...)to cast interpolation/grid-related loaded fields (rbf_*,geofac_*,c_lin_e,c_intp,e_flx_avg,pos_on_tplane_*,nudgecoeff_e) towpfloatbefore constructing diffusion/dycore/diagnostic states.Focused precision regression coverage
wpfloatin both double and single precision modes;Original prompt
Created from VS Code.