Refinements made to the logging outputs as mentioned in issue #89:#91
Merged
harryswift01 merged 2 commits intomainfrom May 13, 2025
Merged
Refinements made to the logging outputs as mentioned in issue #89:#91harryswift01 merged 2 commits intomainfrom
harryswift01 merged 2 commits intomainfrom
Conversation
- Ensured the `.log` file is set to the same level as the logger, not just verbose - MDAnalysis logging levels are the same as the ones used in CodeEntropy - Ensure the correct setting of the logger is enforced in the `update_logging_level` function
3 tasks
… made to the updates in issue #89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR standardizes logging behavior across
CodeEntropy, ensuring consistency in log level handling, including logging fromMDAnalysis. It also improves maintainability by enforcing proper configuration in the logger update logic.Changes
Align log file level with logger configuration
program.logfile handler to dynamically reflect thelog_levelprovided during initialization.Match
MDAnalysislogging level with application log levelMDAnalysislogger during configuration.CodeEntropyverbosity.Enforce logger and handler level updates in
update_logging_levelupdate_logging_levelmethod to update both logger levels and their attached handlers.Impact
CodeEntropy..logfiles by avoiding unnecessary verbosity.