Skip to content

Additional Test Cases for run.py#96

Merged
harryswift01 merged 2 commits intomainfrom
95-improve-test-coverage-for-run
May 15, 2025
Merged

Additional Test Cases for run.py#96
harryswift01 merged 2 commits intomainfrom
95-improve-test-coverage-for-run

Conversation

@harryswift01
Copy link
Member

@harryswift01 harryswift01 commented May 15, 2025

Summary

This PR aims to increase the test coverage for CodeEntropy with adding additional test cases for the run.py file.

Changes

Additional Test Cases:

  • Test to ensure the run_entropy_workflow function operates as expected
  • Test to ensure each ValueError is raised correctly with required arguments top_traj_file and selection_string
  • Tests to ensre the new Universe from MDAnalysis is selected and written as intended

Impact

  • Improves test coverage for critical parts of the CodeEntropy workflow.
  • Increases confidence in error handling and expected behavior.
  • Makes future changes safer by reducing the risk of regressions.

@harryswift01
Additional test cases for run.py:
575089a 
- Test to ensure the `run_entropy_workflow` function operates as expected
- Test to ensure each `ValueError` is raised correctly
- Tests to ensre the new `Universe` from `MDAnalysis` is selected and written as intended
@harryswift01
edits to comments within the new tests for run.py
153226e
@harryswift01 harryswift01 added this to the WP7 - Refactor milestone May 15, 2025
@harryswift01 harryswift01 requested a review from jimboid May 15, 2025 09:11
@harryswift01 harryswift01 self-assigned this May 15, 2025
@harryswift01 harryswift01 linked an issue May 15, 2025 that may be closed by this pull request
Improve Test Coverage for run.py #95
Closed
jimboid
jimboid approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@jimboid jimboid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Improves the testing of critical error handling mechanisms. Go ahead and merge.

@harryswift01 harryswift01 merged commit aa8acbc into main May 15, 2025
6 checks passed
@harryswift01 harryswift01 deleted the 95-improve-test-coverage-for-run branch May 15, 2025 15:01
@jimboid jimboid modified the milestones: WP7 - Refactor, 1.0.0 release Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimboid jimboid jimboid approved these changes

Assignees

@harryswift01 harryswift01

Labels

None yet

Projects

None yet

Milestone

1.0.0 release

Development

Successfully merging this pull request may close these issues.

Improve Test Coverage for run.py

2 participants

@harryswift01 @jimboid