Fix forwarder issues #118
Merged
Fix forwarder issues #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using UDP, templates are periodically resent unlike TCP, where this periodic resending should not happen. Because of a missing check this periodic resending was happening even over TCP.
Adds support for newly introduced "periodic message". Without this change, unfinished data transfers might never finish if no input data is coming.
Unfinished transfers would remain in buffers when we lost connection. In case of TCP, this is a problem. A message might be half-way send when the connection drops, resulting in the other half being sent after the TCP connection reestabilishes. The collector would interpret this as an entirely new message, resulting in bogus data being decoded.
sedmicha
force-pushed
the
fix-forwarder-issues
branch
from
aaf0dd4 to
68ec5a8
Compare
Lukas955
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.