Open
Conversation
Author
|
For additional context, the call was mandatory 7 years ago to avoid memory leaks but is useless since sessions 1.2.0. |
yyewolf
approved these changes
Apr 2, 2026
b40b5f9 to
ee58fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove useless call and associated useless dependency.
It appears that the Clear call only affects data set through gorillaContext.Set which we do not use. Indeed, that's the only call we make to gorilla/context and no dependencies seems to rely on it. (On top of that, its use is discouraged in favor of context.Context since go 1.7.).
Related issues :
Types of changes