Pull deps image on ARM when unchanged, add push retry#63
Merged
harshavemula-ua merged 2 commits intoCIROH-UA:mainfrom Feb 20, 2026
Merged
Pull deps image on ARM when unchanged, add push retry#63harshavemula-ua merged 2 commits intoCIROH-UA:mainfrom
harshavemula-ua merged 2 commits intoCIROH-UA:mainfrom
Conversation
t4g.large was causing Docker daemon crashes due to resource exhaustion during ARM builds, leading to failed image pushes (EOF on docker socket).
b100a04 to
3034902
Compare
JordanLaserGit
approved these changes
Feb 20, 2026
3034902 to
a2616c2
Compare
73a65d8 to
3034902
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ARM build/push execution configuration and the Docker push helper script to improve reliability of image pushes and adjust ARM builder capacity.
Changes:
- Add retry logic (up to 3 attempts) to Docker image tag/push operations in
docker_loginNpush.sh. - Increase ARM EC2 instance type used by ARM push/test executions from
t4g.largetom8g.xlarge.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
docker/docker_loginNpush.sh |
Adds push retry loop for transient failures during tag/push operations. |
.github/executions/fp_push_execution_arm.json |
Bumps ARM builder instance size for push execution. |
.github/executions/fp_ds_test_execution_arm.json |
Bumps ARM builder instance size for DS test execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benlee0423
approved these changes
Feb 20, 2026
…ep after final retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forcingprocessor-depshasn't changed, pull the existing image from Docker Hub instead of rebuilding from scratch on ARMdocker_loginNpush.shto handle transient Docker daemon failuresContext
When only
forcingprocessorversion changed (not deps), the workflow deleted the deps build command from the ARM execution. But sinceforcingprocessorusesFROM awiciroh/forcingprocessor-depsas its base, docker compose rebuilt deps from scratch anyway on the fresh EC2 instance — taking ~1 hour and exhausting resources, causing the Docker socket EOF during push (run 22201325622).Now the workflow substitutes the deps build with
docker pull awiciroh/forcingprocessor-deps:latest-arm64so the base image is available without rebuilding.Files changed
.github/workflows/build_push_fp.yaml— replace deps build delete with docker pulldocker/docker_loginNpush.sh— retry logic for push failuresTest plan
build_push_fp.yamlworkflow with only fp version changed