Skip to content

Fixes remaining bugs in supplychain module#188

Open
spjuhel wants to merge 5 commits into
developfrom
feature/187-fix-bugs-in-supplychain-module
Open

Fixes remaining bugs in supplychain module#188
spjuhel wants to merge 5 commits into
developfrom
feature/187-fix-bugs-in-supplychain-module

Conversation

@spjuhel
Copy link
Copy Markdown
Collaborator

@spjuhel spjuhel commented Nov 5, 2025

This PR fixes #187

It:

  • adds computation of required attributes of the MRIOT when creating them.
  • Fixes the index error that happened when merging results after computation.

PR Author Checklist

PR Reviewer Checklist

@spjuhel spjuhel self-assigned this Nov 5, 2025
@spjuhel
Copy link
Copy Markdown
Collaborator Author

spjuhel commented Nov 5, 2025

This should be very very quick to review (5 min tops), I changed only a few lines.

Copy link
Copy Markdown
Collaborator

@ValentinGebhart ValentinGebhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me. Sorry for the late review!

@emanuel-schmid
Copy link
Copy Markdown
Contributor

The fixes look really neat. (:
However - strictly speaking we ought to have tests for them.

@spjuhel
Copy link
Copy Markdown
Collaborator Author

spjuhel commented Dec 19, 2025

Done!
I actually improved the flow for the mriot member checking.

For the index name test, the mocked dataframe values used in test_calc_indirect_impacts were "too informative" with respect to the value actually returned by their non-mocked corresponding methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants