Refactoring of the forecast tutorial#1070
Closed
emanuel-schmid wants to merge 5 commits into
Closed
Conversation
chahank
approved these changes
Jul 9, 2025
Member
chahank
left a comment
There was a problem hiding this comment.
It looks like together with the typo correction, all the plot have been regenerated. This creates quite a lot of changes in the git log. Do we want this?
Otherwise good to go. I think neither the pre-commit hook fnor petals compatibility failing is related to this PR.
Collaborator
Author
|
@chahank yeah. right. The problem is that every plot change adds to the size of the repository in the range of MBytes. @elianekobler - I know that changing only the relevant lines in a notebook is a bit tricky, but still ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
developbranch as targetThis PR fixes #
PR Author Checklist
develop)PR Reviewer Checklist