Shim class for loading G3SuperTimestream objects from disk#192
Merged
Shim class for loading G3SuperTimestream objects from disk#192
Conversation
Member
Author
|
A couple of missing features that I've noticed so far:
|
4cb3415 to
561ab9c
Compare
afa04ba to
1251e2f
Compare
nwhitehorn
reviewed
Apr 4, 2025
34b13ac to
0335872
Compare
d18ec34 to
c7a7934
Compare
nwhitehorn
reviewed
Apr 9, 2025
nwhitehorn
reviewed
Apr 9, 2025
This PR is the first step in integrating the G3SuperTimestream class used by the Simons Observatory team into the core library. This class is a very thin wrapper around the core G3TimestreamMap class. It is designed only to load G3SuperTimestream objects from G3 files on disk for immediate conversion to G3TimestreamMap objects. It is also not exposed to the public or python API.
For integer data, add a '_nanmask' channel to flag missing samples, and gap-fill with zeros. For floating point data, just gap-fill with nans.
…user space Rearrange, no need for header
tskisner
approved these changes
Apr 22, 2025
Member
tskisner
left a comment
There was a problem hiding this comment.
Thanks for this work! For the record, I tested this branch in combination with a draft PR of so3g that allows building against newer spt3g versions. With that combination, I was able to load some Simons Observatory data through this shim into the downstream sotodlib and toast data containers.
Member
Author
|
I think this is ready to merge, and we can iterate on any missing features in G3TimestreamMap separately. Any objections, @nwhitehorn or @mhasself ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first step in integrating the G3SuperTimestream class used by the Simons Observatory team into the core library. This class is a very thin wrapper around the core G3TimestreamMap class. It is designed only to load G3SuperTimestream objects from G3 files on disk for immediate conversion to G3TimestreamMap objects. It is also not exposed to the public or python API.