Mark important post button resolves #3#10
Open
Skadeven wants to merge 5 commits into
Open
Conversation
Skadeven
force-pushed
the
mark-important-post-button
branch
from
f02a0a0 to
55fac96
Compare
Collaborator
|
@Skadeven is this PR still in progress? |
Contributor
Author
No, I keep this branch for reference of its current progress but will work on another branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3
Effort: 13 hours
Criteria: There is a button attached to posts that can be clicked or unclicked
Progress: Though this issue is frontend, in order to see clear changes when clicking on the button, I also did some backend changes. Currently I modified hundreds of code in both public and src folders with added assertion and typescript translations to the relevant javascript files. And now the website can show a button of pin in the drop down list of both posts and replies for instructor account. And when clicking on it, it now shows invalid API call. This error is due to the lack of changes in the backend code, which is dependent on issue #2.