Implemented sorting at a lower level than before#18
Open
jcheng1103 wants to merge 1 commit into
Open
Conversation
New code for sorting can be found in src/topics/posts.js
Collaborator
|
Looks good to me! |
viviannna
reviewed
Feb 29, 2024
| module.exports = function (Posts) { | ||
| Posts.is_important = async function (pid) { | ||
| return await Posts.getPostField(pid, 'important'); | ||
| // typeof(res) === 'number' or res === null |
Collaborator
There was a problem hiding this comment.
Is there a reason that you commented out this type check?
Otherwise, looks good to me!
Skadeven
force-pushed
the
merging_attempt_2
branch
from
eabbc04 to
95ae88c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code for sorting caused a test case to fail.
The new code cases on whether a post is important and if it is a smaller value is inserted for votes or for timestamp to cause posts to be at the top.
Resolves #8 .