Fix dependencies resolution for conda installation#10
Open
Fix dependencies resolution for conda installation#10
Conversation
…and add missing dep pytz for SunMapGen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix #9 and address installation issues by providing the correct conda install commands in the docs.
Also added a link to the docs in the README and package metadata.
These new commands were successfully tested to create working conda env (at least for Linux).
Notable changes in the dependencies (should work but may require testing) :
All
georastertoolsinstallation which includes dev dependencies - testing and docs - in the mandatory deps).NighOsmReg
gdalversion to 3.11.5fionarequirementpandas3SunMapGen
pytzgdal3.9.3 which is supported by georastertoolsgeorastertoolsdependencies to conda forge available requirements (click geopandas kiwisolver matplotlib fiona scipy pyscaffold, etc.)DetectOrCult
gdalversion to 3.11.5geopandas< 1.0 (i.e. 0.14)pandas<2)fionarequirementThis is a minimal working PR, but my refac recommendation for this repo would be to separate packages. Thus you could specify max python version and handle versions conflicts more easily, by avoiding the "optional dependencies group" trick to specify 3 conflicting deps list.
Suggested structure :
The
environment.yamlis a better way to provide the correct specs to initialize a healthy conda env. It allow to specify conda-forge deps vs pip-only deps, e.g. :Same for DetectOrCult (opencv-contrib-python is not available in conda-forge). This would greatly simplify the
conda createcommand :Ideally the docs should also explain how to install without conda (using
venvandpip, or even better withuv). With the correct dependencies specification and version limits, a pure pip installation in isolated venv shouldn't generate conflicts and installation issues.