Skip to content

updated readme#1

Open
minco3 wants to merge 1 commit into
CS-PCC:masterfrom
minco3:master
Open

updated readme#1
minco3 wants to merge 1 commit into
CS-PCC:masterfrom
minco3:master

Conversation

@minco3

@minco3 minco3 commented Jul 25, 2023

Copy link
Copy Markdown

basic_test.cpp

  • Changed "" for <> as gtest is being included as a library not a relative path
  • Removed main function as Modernize CMakeLists.txt CS3A_Template#1 will link against the gtest_main target which provides its own main function

mac.md

  • Clarified the install guide, now uses GitHub CLI to provide authentication rather than having to create a personal access key.

windows.md

… install guide and rewrote windows install guide to use MSYS2/ucrt64
@minco3 minco3 requested a review from stephengineer July 25, 2023 13:30

@stephengineer stephengineer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect code!

@minco3

minco3 commented Jul 31, 2023

Copy link
Copy Markdown
Author

Glad you like it, I'm going to make another pass and add some more pictures. Should I add a link to Visual Studio Code?

@stephengineer

Copy link
Copy Markdown
Member

and add some more pictures. Should I add a link to Visual Studio Code?

What is the link for?

@minco3

minco3 commented Jul 31, 2023

Copy link
Copy Markdown
Author

What is the link for?

just so people know where to find vscode, I don't think we have a link anywhere but maybe I'm forgetting something.

@stephengineer

Copy link
Copy Markdown
Member

What is the link for?

just so people know where to find vscode, I don't think we have a link anywhere but maybe I'm forgetting something.

Feel free to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants