feat: skeleton and aria-live loading state for test call#131
Merged
greatest0fallt1me merged 3 commits intoJun 3, 2026
Merged
Conversation
… paths, and restore missing Dashboard import
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #98
Implements an accessible loading state for the
ApiUsage"Make Test Call" response area by replacing the plain "Loading..." text with a realistic skeleton loader, adding screen reader accessibility attributes, adding a progress spinner to the action button, and disabling duplicate submissions.Key Changes
Interactive Trigger Button (
src/ApiUsage.tsx):.button-spinner) to the button whenisLoadingis active.disabled={isLoading}) to prevent duplicate submissions.Accessible Loading Region (
src/ApiUsage.tsx):aria-live="polite"andaria-busy={isLoading}to ensure loading and completion states are correctly announced to screen readers (meeting WCAG 2.1 AA 4.1.3).src/components/Skeleton.tsxcomponent, simulating the structure of the JSON payload.Styling & Theme Support (
src/index.css):@keyframes spinanimation and loader styling using existing design tokens.Verification Results
tsc -b && vite build) which compiles cleanly without any warnings or errors.