Task/method badge tokens#132
Merged
greatest0fallt1me merged 4 commits intoJun 3, 2026
Merged
Conversation
… paths, and restore missing Dashboard import
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged via direct push to main (admin) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #99
Implements highly accessible, token-based, color-blind-safe HTTP method badges for endpoint documentation in
ApiDetailPage. The old hard-coded inline ternary (which collapsed all non-GET requests to the same green color) is replaced by centralized, theme-responsive classes and custom variables that ensure robust text contrast and distinct semantic palettes for each HTTP method.Key Changes
Token-Based Theme Styling (
src/index.css):--method-{method}-bg,--method-{method}-color,--method-{method}-border) for each standard HTTP method (GET, POST, PUT, DELETE, PATCH).Visual Distinctness & Accessibility:
.method-badge,.method-badge--get, etc.) instead of hard-coded inline values.GET,POST,PUT,DELETE, andPATCH. By using explicit text identifiers inside the badges, the meaning is never conveyed by color alone (fully satisfying WCAG 2.1 AA 1.4.1 - Use of Color).Badges Rendering Integration (
src/pages/ApiDetailPage.tsx):<span style={{...}}>with modern, dynamic CSS class assignment:className={"method-badge method-badge--" + (ep.method || "get").toLowerCase()}.Verification Results
tsc -b && vite build) which compiles cleanly without any warnings or errors.