Feature/price filter validation#133
Merged
greatest0fallt1me merged 5 commits intoJun 3, 2026
Merged
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged via direct push to main (admin) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #101
Implements highly accessible validation, bounds checking, negative clamping, and inverted-range handling for the price range filter in
FiltersSidebaron the API Marketplace page. This ensures users receive immediate visual and structural feedback when inputting an invalid range, and guards the API filter logic against silently emptying the results view without explanation.Key Changes
Robust Price Input Validation (
src/components/FiltersSidebar.tsx):min="0") directly on the min/max input elements.Math.max(0, ...)logic on input change handlers to automatically clamp negative values.minPrice > maxPrice.aria-invalidattributes and linked them dynamically to the inline validation text usingaria-describedby="price-range-error", strictly adhering to accessibility best practices.Centralized & Premium Validation Styles (
src/index.css):.filter-input) matching other select form components..filter-input--invalid) which turns the input borders red and sets custom high-contrast focus rings when bounds are violated.Smart Filtering Guard Logic (
src/pages/MarketplacePage.tsx):useMemoso that when an inverted price range is detected (minPrice > maxPrice), the invalid range is ignored instead of silently removing all APIs from the list.Verification Results
tsc -b && vite build) which compile cleanly without any warnings or errors.