Skip to content

fix: restore readable text in PRCreateModal branch dropdowns on dark theme #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
R-Hart80 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: restore readable text in PRCreateModal branch dropdowns on dark theme #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02a0b0
fix: mirror Expand layout in Collapse split-button group
R-Hart80 May 11, 2026
5896f0b
fix: restore readable text in PRCreateModal branch dropdowns on dark …
R-Hart80 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions components/editor/shared/EntityTreeToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,21 @@ export function EntityTreeToolbar({
{showCollapseGroup && (
<div className="flex rounded-md border border-slate-200 dark:border-slate-600">
<button
onClick={onCollapseAll}
onClick={onCollapseOneLevel}
disabled={collapseDisabled}
className={cn(btnBase, "rounded-l-md border-r border-slate-200 dark:border-slate-600", collapseDisabled ? btnDisabled : btnEnabled)}
aria-label="Collapse all"
aria-label="Collapse one level"
>
<ChevronsRight className="h-3.5 w-3.5" />
<ChevronRight className="h-3.5 w-3.5" />
<span className="hidden sm:inline">Collapse</span>
</button>
<button
onClick={onCollapseOneLevel}
onClick={onCollapseAll}
disabled={collapseDisabled}
className={cn(btnBase, "rounded-r-md px-1", collapseDisabled ? btnDisabled : btnEnabled)}
aria-label="Collapse one level"
aria-label="Collapse all"
>
<ChevronRight className="h-3.5 w-3.5" />
<ChevronsRight className="h-3.5 w-3.5" />
</button>
</div>
)}
Expand Down
8 changes: 4 additions & 4 deletions components/pr/PRCreateModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,10 @@ export function PRCreateModal({
<select
value={sourceBranch}
onChange={(e) => setSourceBranch(e.target.value)}
className="flex-1 rounded-sm border-0 bg-transparent py-1 text-sm focus:outline-hidden focus:ring-0"
className="flex-1 rounded-sm border-0 bg-transparent py-1 text-sm text-slate-900 focus:outline-hidden focus:ring-0 dark:text-white"
>
{branches.map((branch) => (
<option key={branch.name} value={branch.name}>
<option key={branch.name} value={branch.name} className="bg-white text-slate-900 dark:bg-slate-700 dark:text-white">
{branch.name}
</option>
))}
Expand All @@ -137,10 +137,10 @@ export function PRCreateModal({
<select
value={targetBranch}
onChange={(e) => setTargetBranch(e.target.value)}
className="flex-1 rounded-sm border-0 bg-transparent py-1 text-sm focus:outline-hidden focus:ring-0"
className="flex-1 rounded-sm border-0 bg-transparent py-1 text-sm text-slate-900 focus:outline-hidden focus:ring-0 dark:text-white"
>
{branches.map((branch) => (
<option key={branch.name} value={branch.name}>
<option key={branch.name} value={branch.name} className="bg-white text-slate-900 dark:bg-slate-700 dark:text-white">
{branch.name}
</option>
))}
Expand Down
Loading