Pastafazool I am a fool (A few minor fixes (Colored giltsilk names, mole fur, butchery fix(?)))#500
Open
Ghostcoffeee wants to merge 2 commits into
Open
Pastafazool I am a fool (A few minor fixes (Colored giltsilk names, mole fur, butchery fix(?)))#500Ghostcoffeee wants to merge 2 commits into
Ghostcoffeee wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
There was a bug report in the discord that stated that the colored giltsilk stuff ported from deserttown didn't have names. They were also weirdly subtyped as
exoticsilkbelt/redinstead of being the normal giltsilk's (silkbelt) subtype. I changed thatI had forgotten to remove the
subtype_reqs = FALSEfrom the giant fur/giant pelt recipes, which made them need base fur. Now it can use any fur type.Moles dropped generic, untyped fur, despite there being a /mole fur subtype. Now they drop their own specific fur.
Direbear furs suddenly turned black when butchering. The uncolored sprite looks nice, and fits the mob sprite better.
A lot of mobs have their
perfect_butcher_resultslist longer than the regularbutcher_resultsone, which in most cases caused them to not even check the last perfect results. I added a check in the butchery proc to see which of the (initial) list length is longer, and use that count for checking loot. As far as I tested, it didn't cause any weirdness.I will be sad if it breaks, and will try desperately to fix it