Fix/update fix nu6 #153

sqhell · 2026-01-07T19:09:41Z

Changes

Migrated from ChainSafe librustzcash fork (46e8ee09) to official zcash/librustzcash (a40ee353) per PR Point upstream librustcash #139
Updated WebWallet constructor to use new ConfirmationsPolicy API (trusted/untrusted confirmations)
Added validation module with unit tests for confirmations policy parameter validation
Fixed e2e test infrastructure: added COOP/COEP headers for SharedArrayBuffer support
Updated Playwright config with proper browser args and timeout for WASM loading

Details

The breaking change was the Zcash NU6 (Network Upgrade 6) update in the official librustzcash.

Specifically:

Version	Status
ChainSafe fork 46e8ee09	Was working (old)
Official c3425f9c3	Broken (bip32 0.6.0-pre.1 dependency hell)
Official a40ee353	Working (what PR #139 uses)

Quick Checklist for Infra Team

Item	Action Required
COOP/COEP headers	Yes - add to production web server
WebWallet constructor	Yes - update all call sites
Dependencies	No - handled at build time
Database schema	No changes
API endpoints	No changes
Build commands	No changes

Test Before Deploying

They can verify headers are working by checking browser console:
// Should return true if headers are set correctly
console.log(typeof SharedArrayBuffer !== 'undefined')

Tests

Run unit tests for ConfirmationsPolicy validation

cargo test --package webzjs-wallet --lib validation

Run e2e tests (requires yarn and playwright)

cd packages/e2e-tests
yarn install
npx playwright test --project=chromium

Issues

Fixes compatibility with NU6 network upgrade
Resolves SharedArrayBuffer initialization failures in Chromium browsers

irubido

Looks good to me,
but still wallet does not work when built in WASM.

got this error in browser console

webzjs_wallet.js:1621 panicked at /home/ivan/.cargo/git/checkouts/librustzcash-c2c6180a1a11d4fa/a40ee35/zcash_client_memory/src/wallet_read.rs:734:9:
not yet implemented

rob1997 · 2026-01-22T10:02:08Z

@sqhell has the WASM panic issue been resolved?

Looks good to me, but still wallet does not work when built in WASM.

got this error in browser console
webzjs_wallet.js:1621 panicked at /home/ivan/.cargo/git/checkouts/librustzcash-c2c6180a1a11d4fa/a40ee35/zcash_client_memory/src/wallet_read.rs:734:9:
not yet implemented

➕

rob1997

Fix the WASM panic by ensuring the librustzcash fork has the required implementation
Test WASM build in browser environment
Verify get_wallet_summary() works after wallet creation
Update README.md to reflect new constructor signature (currently shows old API), line 37 to show new constructor

LesnyRumcajs · 2026-01-22T12:53:55Z

@rob1997 I'm not a maintainer of this repository, so I can't really give this change an insightful review.

rob1997 · 2026-01-22T15:26:21Z

@rob1997 I'm not a maintainer of this repository, so I can't really give this change an insightful review.

gotcha, no worries. besides @sqhell we're all rust noobs here that's why I had assigned you :)

irubido · 2026-01-22T15:48:58Z

Great job with fix, just some of functionality still throws errors

Managed to sync to block 2978667 quite fast 👍 , transaction worked both to u ant t address.
Only got panic when trying to shield funds after sending them to t address

webzjs_wallet.js:1664 panicked at /home/ivan/.cargo/git/checkouts/librustzcash-nu61-7767c02336992644/0ec0723/zcash_client_backend/src/data_api.rs:1866:9:
not implemented: WalletRead::get_transparent_address_metadata must be overridden for wallets to use the `transparent-inputs` feature

On page refresh i got errors

Saved wallet detected. Restoring wallet from storage
webzjs_wallet.js:1727  INFO webzjs_wallet::bindgen::wallet: Serialized db was provided to constructor. Attempting to deserialize

webzjs_wallet.js:1664 panicked at /home/ivan/.cargo/git/checkouts/librustzcash-nu61-7767c02336992644/0ec0723/zcash_client_memory/src/types/transparent.rs:191:66:
FIXME

and toast message passed to webapp

Wallet data incompatible after upgrade. Please re-sync your wallet.

rob1997 · 2026-01-28T12:23:10Z

@sqhell Thanks for addressing the previous feedback.
remaining issues were

Shielding Panic (Medium Priority)

panicked at .../data_api.rs:1866:9:not implemented: WalletRead::get_transparent_address_metadata must be overridden
Impact: Users cannot shield transparent funds after sending to t-address

Action needed: Verify/implement get_transparent_address_metadata in the ChainSafe/librustzcash-nu61 fork

Wallet Restore Panic (High Priority)
panicked at .../transparent.rs:191:66: FIXME
Impact: Wallet restore from storage fails on page refresh (gracefully handled, but forces re-sync)
Action needed: Resolve the FIXME in transparent.rs:191 in the librustzcash fork

lmk if these are already implemented

sqhell · 2026-01-28T12:33:18Z

@sqhell Thanks for addressing the previous feedback. remaining issues were

Shielding Panic (Medium Priority)
panicked at .../data_api.rs:1866:9:not implemented: WalletRead::get_transparent_address_metadata must be overridden
Impact: Users cannot shield transparent funds after sending to t-address
Action needed: Verify/implement get_transparent_address_metadata in the ChainSafe/librustzcash-nu61 fork

Wallet Restore Panic (High Priority)
panicked at .../transparent.rs:191:66: FIXME
Impact: Wallet restore from storage fails on page refresh (gracefully handled, but forces re-sync)
Action needed: Resolve the FIXME in transparent.rs:191 in the librustzcash fork

lmk if these are already implemented

@rob1997 cargo update -p zcash_client_memory , you have a cached version, that should fix it

irubido · 2026-01-29T13:26:08Z

Great work, all functionality works without throwing errors. And especially implementing transaction history: 👍

One issue I found is:
I synced wallet from year ago, block 2811355, then I transefered 0.01 ZEC to it. With all transactions it synec to 0.089 which does seem fine.

Then I closed the browser window and opened again, and balance shwed is 0.01285 ZEC.
Wallet changed balance just from closing the window.

This happened 2 times, I reproduced it twice, once with closer block and it also changed balance after re-opening the app.

irubido · 2026-01-29T13:29:18Z

.github/workflows/check-snap-allowed-origins.yml

    branches: [ main ]
    paths:
-      - 'packages/snap/snap.manifest.json'
+      - 'packages/snap/snap.manifest.base.json'


this workflow should check original snap.manifest.json

irubido · 2026-01-29T13:39:04Z

packages/snap/package.json

+    "start": "yarn manifest:dev && mm-snap watch",
+    "dev": "yarn manifest:dev && mm-snap watch",


readmes need to be updated for new dev scripts

irubido · 2026-01-29T13:42:28Z

packages/web-wallet/src/config/constants.ts

@@ -1,4 +1,8 @@
-export const MAINNET_LIGHTWALLETD_PROXY = 'https://zcash-mainnet.chainsafe.dev';
+// For local development (with docker proxy running: docker compose -f traefik/docker-compose.yml up -d)
+export const MAINNET_LIGHTWALLETD_PROXY = 'http://localhost:1234/mainnet';


this way localhost will be published by workflow to production

irubido · 2026-01-29T13:43:17Z

packages/web-wallet/src/config/constants.ts

@@ -1,4 +1,8 @@
-export const MAINNET_LIGHTWALLETD_PROXY = 'https://zcash-mainnet.chainsafe.dev';
+// For local development (with docker proxy running: docker compose -f traefik/docker-compose.yml up -d)
+export const MAINNET_LIGHTWALLETD_PROXY = 'http://localhost:1234/mainnet';


also readme update is needed if dev flow is changed

irubido · 2026-01-29T13:51:55Z

There is also flow bug, on initial flow creation user is asked to allow viewingKey from snap twice.

ec2 and others added 3 commits November 14, 2025 13:59

change commit hash and repo

7217c84

compiles now

873f236

CS - fixes for handling NU6 network upgrade

76733a9

sqhell requested a review from salindne January 7, 2026 19:10

fix: apply cargo fmt formatting

9d804cf

sqhell requested a review from irubido January 7, 2026 20:47

sqhell added 2 commits January 8, 2026 11:18

fix: update WebWallet constructor and add graceful upgrade handling

b8f0b01

chore: update playwright webserver timeout and snap manifest

657c960

irubido requested changes Jan 9, 2026

View reviewed changes

sqhell added 3 commits January 20, 2026 05:57

Initial nu61 upgrade

ea28ac4

fix: test path references

2f7f549

fix: remove localhost from allowedOrigins and fix cargo fmt

c2ef96e

sqhell requested review from irubido and rob1997 January 20, 2026 14:25

sqhell mentioned this pull request Jan 21, 2026

Update librustzcash to 6.1 #154

Open

rob1997 reviewed Jan 22, 2026

View reviewed changes

rob1997 requested review from LesnyRumcajs and ec2 January 22, 2026 10:24

fix: new cargo files with new info

415a2e1

LesnyRumcajs removed their request for review January 22, 2026 12:54

sqhell added 2 commits January 22, 2026 08:22

fix: agnostic install and recover account fix

b01a15f

fix: better dev-prod variables handling to not break CI

dd615bd

sqhell added 2 commits January 27, 2026 08:23

fix: transfers, transaction history

4d36c94

fix: formatting

f1c645d

irubido requested changes Jan 29, 2026

View reviewed changes

		"start": "yarn manifest:dev && mm-snap watch",
		"dev": "yarn manifest:dev && mm-snap watch",

Fix/update fix nu6 #153

Are you sure you want to change the base?

Fix/update fix nu6 #153

Uh oh!

Conversation

sqhell commented Jan 7, 2026

Changes

Details

Quick Checklist for Infra Team

Test Before Deploying

Tests

Run unit tests for ConfirmationsPolicy validation

Run e2e tests (requires yarn and playwright)

Issues

Uh oh!

irubido left a comment

Choose a reason for hiding this comment

Uh oh!

rob1997 commented Jan 22, 2026

Uh oh!

rob1997 left a comment

Choose a reason for hiding this comment

Uh oh!

LesnyRumcajs commented Jan 22, 2026

Uh oh!

rob1997 commented Jan 22, 2026

Uh oh!

irubido commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rob1997 commented Jan 28, 2026

Uh oh!

sqhell commented Jan 28, 2026

Uh oh!

irubido commented Jan 29, 2026

Uh oh!

irubido Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

irubido Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

irubido Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

irubido Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

irubido commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

irubido commented Jan 22, 2026 •

edited

Loading