Skip to content

Rounded bars#4339

Closed
idcuesta wants to merge 9 commits intoChartsOrg:masterfrom
SolarCS:rounded-bars
Closed

Rounded bars#4339
idcuesta wants to merge 9 commits intoChartsOrg:masterfrom
SolarCS:rounded-bars

Conversation

@idcuesta
Copy link
Copy Markdown

JIRA

Description

This PR add next changes in order to be able to reproduce design for bar charts as described in this image:

bar-charts

  • Added rounded corners to bars in bar chart through config option drawRoundedBarEnabled
  • Added rounded lines to legend form through config option formLineRoundedCap

@liuxuan30
Copy link
Copy Markdown
Member

liuxuan30 commented Apr 17, 2020

which rounded bar PR is this PR derived from? Or the code is writen by yourself?
We have #3754 #1917

@liuxuan30
Copy link
Copy Markdown
Member

it looks like similar from #1917 , which I think not as good as #3754.

@liuxuan30
Copy link
Copy Markdown
Member

liuxuan30 commented Apr 17, 2020

I will have to close this as we already had similar PRs.
besides, it has the same defect as I said in #1917 (comment)

@liuxuan30 liuxuan30 closed this Apr 17, 2020
@idcuesta
Copy link
Copy Markdown
Author

Ups, apologies, this was supposed to be added to our own fork, not here

@liuxuan30
Copy link
Copy Markdown
Member

liuxuan30 commented Apr 17, 2020

@idcuesta I'd suggest you take a look at #3754, which seems a better solution. We had issues to get it merged into master any time soon, so if you are interested in it, maybe you can take a look at file a new PR(no pressure for you though)

@idcuesta
Copy link
Copy Markdown
Author

Thanks! I have seen that PR, waiting for it to get merged (this solution is just a simplistic patch for what we need at the moment) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants