Fixed: Pie Chart percentage does not display on demo project#5143
Open
leson1106 wants to merge 1 commit intoChartsOrg:masterfrom
Open
Fixed: Pie Chart percentage does not display on demo project#5143leson1106 wants to merge 1 commit intoChartsOrg:masterfrom
leson1106 wants to merge 1 commit intoChartsOrg:masterfrom
Conversation
Naveen-C-Ramachandrappa
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
I didn't see any issues relevant to this. However, it's happening on both Swift and Objective-c targets in the demo project. The Pie Chart percentage doesn't show up even
DefaultValueFormatterwas set.Goals Soccer ⚽
Make Pie Chart percentage show up.
Implementation Details 🚧
Move
NumberFormatterconstructor andsetValueFormatter(formatter:)function belowchartView.data = data. I saw on thedidSetimplementation ofChartData, that each data in ChartData will be re-assigned todefaultValueFormatterif thevalueFormatterof each data is a DefaultValueFormatter subtype. So, no matter what formatter is set, it will be replaced.Testing Details 🔍
I've tested on both Swift and Objective-c targets. It works as expected.