Add corner radius in Barchart#5185
Closed
Khanak1521 wants to merge 4 commits intoChartsOrg:masterfrom
Closed
Conversation
|
when this feature will be added and merged? |
Member
|
looks unlikely, the implementation of this will has an issue: when the bar is too thin, it will look like an Oval rather than a bar. |
| s.tvos.deployment_target = "12.0" | ||
| s.osx.deployment_target = "10.13" | ||
| s.source = { :git => "https://github.com/danielgindi/Charts.git", :tag => "#{s.version}" } | ||
| s.source = { :git => "https://github.com/Khanak1521/Charts.git", :tag => "#{s.version}" } |
There was a problem hiding this comment.
I think we need to undo this git url change
|
|
||
| context.fill(barRect) | ||
| let rectCorners: UIRectCorner = [.topLeft, .topRight] | ||
| let bezierPath = UIBezierPath(roundedRect: barRect, byRoundingCorners: rectCorners, cornerRadii: CGSize(width: self.barChartCornerRedius, height: self.barChartCornerRedius)) //(roundedRect: barRect, byRoundingCorners: rectCorners, cornerRadi: 5) |
|
What is the state of this now? |
Seems author (@Khanak1521) of this PR is not actively looking into this. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Goals ⚽
Implementation Details 🚧
Testing Details 🔍