Fix crash in BarLineScatterCandleBubbleRenderer.swift when converting maxVisibleCount greather than Int.max#5246
Open
mipolansk wants to merge 1 commit intoChartsOrg:masterfrom
Open
Fix crash in BarLineScatterCandleBubbleRenderer.swift when converting maxVisibleCount greather than Int.max#5246mipolansk wants to merge 1 commit intoChartsOrg:masterfrom
mipolansk wants to merge 1 commit intoChartsOrg:masterfrom
Conversation
… maxVisibleCount greather than Int.max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
There is a problem when you zoom a lot. The app crashes because CGFloat cannot be converted to Int. It is bigger then Int.max. To avoid this crash, additional check is added.
Implementation Details 🚧
Just a check if count: CGFloat is smaller then Int.max
Testing Details 🔍
The easiest way is open the app on macos. Set pinZoomEnabled to true and zoom in a lot.