fix: reset timePassed when timer duration is changed in study timer#697
Open
akhilmodi29 wants to merge 1 commit into
Open
fix: reset timePassed when timer duration is changed in study timer#697akhilmodi29 wants to merge 1 commit into
akhilmodi29 wants to merge 1 commit into
Conversation
Author
|
@Charushi06 Please review this PR and add the required labels including gssoc:approved. This fixes the timer timePassed not reset bug in study timer. Labels suggested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #696
Problem
When a user changes the timer duration after pausing mid-session,
timePassed was never reset to 0. This caused:
Fix
Added timePassed = 0 inside the timerDurationInput change
handler so elapsed time is always reset when duration changes.
Also removed the timePassed === 0 condition since we now
always reset it on duration change.
Testing