Skip to content

fix(agent): 明确 pending 消息消费决策#810

Open
CookSleep wants to merge 1 commit intoChatLunaLab:v1-devfrom
CookSleep:fix/pending-message-decision
Open

fix(agent): 明确 pending 消息消费决策#810
CookSleep wants to merge 1 commit intoChatLunaLab:v1-devfrom
CookSleep:fix/pending-message-decision

Conversation

@CookSleep
Copy link
Copy Markdown
Member

Summary

  • 将 agent 的 round-decision 语义从 canContinue 明确为 willConsumePendingMessages,让 pending message 消费决策更直观
  • character_reply 最终完成分支补充 reply-emitted 标记与 pending drain,避免回复已由工具发送时 trace 仍表现为空输出
  • 同步主聊天服务对新事件字段的消费逻辑

Verification

  • yarn fast-build core

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

Warning

Rate limit exceeded

@CookSleep has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 24 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 24 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7af23fd5-5e8b-48e1-bf3a-63fed6945906

📥 Commits

Reviewing files that changed from the base of the PR and between 086a1f7 and 70814bb.

📒 Files selected for processing (4)
  • packages/core/src/llm-core/agent/legacy-executor.ts
  • packages/core/src/llm-core/agent/sub-agent.ts
  • packages/core/src/llm-core/agent/types.ts
  • packages/core/src/services/chat.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CookSleep CookSleep force-pushed the fix/pending-message-decision branch from 959b58e to 70814bb Compare April 3, 2026 05:29
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the canContinue property to willConsumePendingMessages across the agent execution and chat service logic to more accurately describe its function. It also introduces a mechanism to handle final character replies emitted by tools, adding a replyEmitted flag to the done event and updating the UI to reflect when a reply has been sent by a tool. Furthermore, the Docker configuration guide for the extension agent has been updated with recommendations for setting home and working directories, and the parameter descriptions for the group mute tool have been refined for better clarity. I have no feedback to provide as there were no review comments to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant