Skip to content

Transposes minor keys to relative major #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MerijnBosma wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Transposes minor keys to relative major #622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31781c8
Transposes minor keys to relative major
MerijnBosma Nov 19, 2025
b6dd595
Handles transcoded keys in Nashville notation
MerijnBosma Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions lib/ChordPro/Song.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2659,15 +2659,31 @@ sub parse_chord {
}
}

if ( $xc && $info ) {
my $key_ord;
$key_ord = $self->{chordsinfo}->{$self->{meta}->{key}->[-1]}->{root_ord}
if $self->{meta}->{key};
if ( $xcmov && !defined $key_ord ) {
do_warn("Warning: Transcoding to $xc without key may yield unexpected results\n");
undef $xcmov;
}
my $i = $info->transcode( $xc, $key_ord );
if ( $xc && $info ) {
my $key_ord;
if ( $self->{meta}->{key} ) {
my $key_name = $self->{meta}->{key}->[-1];
my $key_info = $self->{chordsinfo}->{$key_name};

# If the key was already transcoded, get the original
if ( $key_info->{xc} ) {
$key_info = $key_info->{xc};
}

$key_ord = $key_info->{root_ord};
# For Nashville/Roman notation, convert minor keys to relative major
if ( $xcmov && $key_info->{qual_canon} && $key_info->{qual_canon} eq "-" ) {
# Minor key: transpose up 3 semitones to get relative major
my $p = ChordPro::Chords::get_parser();
$key_ord = ( $key_ord + 3 ) % $p->intervals;
}
}
if ( $xcmov && !defined $key_ord ) {
do_warn("Warning: Transcoding to $xc without key may yield unexpected results\n");
undef $xcmov;
}
my $i = $info->transcode( $xc, $key_ord );

# Prevent self-references.
$i->{xc} = $info unless $i eq $info;
$info = $i;
Expand Down