Adds setup:codespaces command#35
Conversation
walangitan
requested review from
adamzimmermann and
markdorison
and removed request for
markdorison
adamzimmermann
left a comment
adamzimmermann
left a comment
There was a problem hiding this comment.
I'm not sure if you are looking for final approval on this, or just a review, so I'll just leave a comment for now.
I'm guessing you want to finish the parent PR while using this as a dev branch and then merge this and tag it for release?
|
Overall this is looking great so far! 💯 |
| $result = $this->taskExec('rm')->args($dbPath)->run(); | ||
|
|
||
| $this->io()->section('Building theme.'); | ||
| $result = $this->taskExec('composer robo theme:build')->run(); |
There was a problem hiding this comment.
This and the db download line above will work for simple sites, but multi-sites will require some special cases. I am OK with merging this assuming we want to address that in a future update.
There was a problem hiding this comment.
I can log a ticket about updating this to support multi-sites, as well as some other caveats that may need to be created to support running a multi-site in codespaces.
agarzola
left a comment
agarzola
left a comment
There was a problem hiding this comment.
@walangitan This PR appears to perform all the tasks we need it to complete. However, I did notice in the web VSCode terminal that the process does not appear to exit:
@adamzimmermann @markdorison Is there something we need to run here to explicitly exit the process once a task has completed? As far as I can tell, the new setupCodespaces() function looks like just any other, so I doubt there is anything else we’re missing here, but I ask just in case.
No, not that I am aware of. 😕 |
4 participants
Description
Adds a
setup:codespacescommand that does the following:/var/www/htmlto the/webdirectory on a site.Motivation / Context
https://github.com/ChromaticHQ/chromatichq.com/pull/3472/ has issues when executing other robo commands from another robofile, returning a
$resultobject instead of a string that we need for our database imports.Testing Instructions / How This Has Been Tested
Testing in the https://github.com/ChromaticHQ/chromatichq.com/pull/3472/ codespace.
Screenshots
TBD
Documentation
TBD